feature: useSSE() basic implement #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JOU-amjs
reviewed
Apr 11, 2024
| const fullURL = buildCompletedURL(baseURL, url, params); | ||
| const eventSource = new EventSource(fullURL, { withCredentials: config.withCredentials }); | ||
|
|
||
| const { data, update } = useRequest(handler, config); |
There was a problem hiding this comment.
这里为什么要通过useRequest来创建data，是不是直接$(config.initialData)就可以了
Comment on lines
+57
to
+78
| const createSSEEvent = (eventName: string, event: MessageEvent<any> | Event) => { | ||
| if (eventName === 'open') { | ||
| return { | ||
| method: methodInstance, | ||
| eventSource | ||
| } as AlovaSSEEvent; | ||
| } | ||
| if (eventName === 'error') { | ||
| return { | ||
| method: methodInstance, | ||
| eventSource, | ||
| error: new Error('sse error') | ||
| } as AlovaSSEErrorEvent; | ||
| } | ||
|
|
||
| // 其余名称的事件都是（类）message 的事件，data 交给 dataHandler 处理 | ||
| return { | ||
| method: methodInstance, | ||
| eventSource, | ||
| data: dataHandler((event as MessageEvent).data) | ||
| } as AlovaSSEMessageEvent<any>; | ||
| }; |
There was a problem hiding this comment.
可能你没注意到createHookEvent这个文件，应该是可以使用这个函数，然后调整下对SSE的事件对象的支持能用上。
|
|
||
| return { | ||
| readyState: _exp$(readyState), | ||
| data, |
There was a problem hiding this comment.
这个最好也可以_exp$一下，在react中可直接用
Comment on lines
+358
to
+360
| if (callbacks) { | ||
| return forEach(callbacks, fn => fn(args)); | ||
| } |
There was a problem hiding this comment.
这个判断好像无效，因为按你写的callbacks至少都会是一个空数组
| const setCallback = (fn: Fn) => { | ||
| if (!callbacks.includes(fn)) { | ||
| callbacks.push(fn); | ||
| onCallbackChange && onCallbackChange(callbacks); |
There was a problem hiding this comment.
我提下我的见解，如果我的话，我会把onCallbackChange接收处默认为noop，这样就不需要多个地方判断onCallbackChange是否有值，当然你这样写也没啥问题。
|
|
||
| // type: eventname & useCallback() | ||
| const eventMap: Map<string, ReturnType<typeof useCallback>> = new Map(); | ||
| const [onOpen, triggerOnOpen, offOpen] = useCallback<SSEOnOpenTrigger>(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.